Skip to content

<feature>[sdk]: regenerate SDK for RegexAgainst/NotEqual operators#3785

Open
zstack-robot-2 wants to merge 1 commit into5.4.8from
sync/moyu/ZSTAC-84412@@2
Open

<feature>[sdk]: regenerate SDK for RegexAgainst/NotEqual operators#3785
zstack-robot-2 wants to merge 1 commit into5.4.8from
sync/moyu/ZSTAC-84412@@2

Conversation

@zstack-robot-2
Copy link
Copy Markdown
Collaborator

@zstack-robot-2 zstack-robot-2 commented Apr 17, 2026

Regenerated by ./runMavenProfile sdk from updated
@APIParam.validValues on APIAddLabelToAlarmMsg and
APIUpdateAlarmLabelMsg in premium repo (same Jira). Lets SDK
clients pass RegexAgainst and NotEqual as the operator field
for alarm labels, matching the server-side API interceptor.

APIImpact: AddLabelToAlarm/UpdateAlarmLabel SDK Action now accepts
RegexAgainst and NotEqual operator values.
Resolves: ZSTAC-84412

Change-Id: I7574667a706b646a696d6162616b686a69726769

sync from gitlab !9654

<feature>[sdk]: regenerate SDK for RegexAgainst/NotEqual operators
9c88121 
Regenerated by ./runMavenProfile sdk from updated
@APIParam.validValues on APIAddLabelToAlarmMsg and
APIUpdateAlarmLabelMsg in premium repo (same Jira). Lets SDK
clients pass RegexAgainst and NotEqual as the operator field
for alarm labels, matching the server-side API interceptor.

APIImpact: AddLabelToAlarm/UpdateAlarmLabel SDK Action now accepts
RegexAgainst and NotEqual operator values.
Resolves: ZSTAC-84412

Change-Id: I7574667a706b646a696d6162616b686a69726769
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • sdk/src/main/java/org/zstack/sdk/zwatch/alarm/AddLabelToAlarmAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/zwatch/alarm/UpdateAlarmLabelAction.java is excluded by !sdk/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 90c62896-0e4b-427d-aa72-ffac36e844ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/moyu/ZSTAC-84412@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix
Copy link
Copy Markdown
Owner

MatheMatrix commented Apr 20, 2026

Comment from yaohua.wu:

Review: MR !9654 — ZSTAC-84412

结论：APPROVED ✅ — SDK 自动生成文件，与 premium 侧 API 变更一致。

变更概要

本 MR 由 ./runMavenProfile sdk 自动生成，将 AddLabelToAlarmAction 和 UpdateAlarmLabelAction 的 operator 字段 validValues 从 {"Regex","Equal"} 扩展为 {"Regex","Equal","RegexAgainst","NotEqual"}，与 premium 仓库 MR !13572 中 APIAddLabelToAlarmMsg / APIUpdateAlarmLabelMsg 的 @APIParam 变更保持同步。

逐文件 Review

1. sdk/.../AddLabelToAlarmAction.java

- @Param(required = true, validValues = {"Regex","Equal"}, ...)
+ @Param(required = true, validValues = {"Regex","Equal","RegexAgainst","NotEqual"}, ...)

✅ 与 premium 侧 APIAddLabelToAlarmMsg 一致。

2. sdk/.../UpdateAlarmLabelAction.java

- @Param(required = true, validValues = {"Regex","Equal"}, ...)
+ @Param(required = true, validValues = {"Regex","Equal","RegexAgainst","NotEqual"}, ...)

✅ 与 premium 侧 APIUpdateAlarmLabelMsg 一致。

总结

维度 评价
正确性 ✅ SDK 与 API 定义一致
向后兼容 ✅ 纯增量，现有值不变
风险 极低 — 自动生成文件

详细 Review 见配套 premium MR: premium !13572

🤖 Robot Reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zstack-robot-2 @MatheMatrix